Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fulcio-server -> fulcio-url, pkg/fulcio refactoring #471

Merged
merged 1 commit into from
Jul 22, 2021
Merged

fulcio-server -> fulcio-url, pkg/fulcio refactoring #471

merged 1 commit into from
Jul 22, 2021

Conversation

dekkagaijin
Copy link
Member

@dekkagaijin dekkagaijin commented Jul 22, 2021 •
edited
Loading

  • fulcio-url is more descriptive and consistent with Rekor
  • raw PEMs are canonically []bytes in the standard lib

Signed-off-by: Jake Sanders jsand@google.com

@dekkagaijin dekkagaijin requested a review from dlorenc July 22, 2021 20:50
fulcio-server -> fulcio-url, pkg/fulcio refactoring
e712bba 
Signed-off-by: Jake Sanders <jsand@google.com>
@dlorenc dlorenc merged commit d401496 into main Jul 22, 2021
@dlorenc dlorenc deleted the fulcio-url branch July 22, 2021 21:16
@cpanato cpanato added this to the v1.0.0 milestone Jul 23, 2021
@renovate renovate bot mentioned this pull request Jul 28, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dekkagaijin @dlorenc @cpanato